You’re viewing Paradaux’s public workspaceSign in to vote Get taskl.ie for your team

PAR-22

Loading issues

PAR-22 · Expose a firm's total balance in the business plugin API · Paradaux · taskl.ie

PAR-22

Expose a firm's total balance in the business plugin API

Expose a firm's total balance (summed across its accounts) in the public business plugin API.

Technical notes — business-api's FirmApi/StaffApi expose no balance accessor; the logic already exists internally as FirmTransactionService.getAggregateBalance(firmId) (sum over FirmAccountsMapper.listAccountsByFirm via treasury.getBalanceByAccountId). Add BigDecimal getTotalBalance(int firmId) (+ formatted variant) to FirmApi, implement in FirmApiDelegate by delegating to FirmTransactionService (inject it into BusinessApiImpl). Prerequisite for PAR-57.

Activity

tesks assigned the issue to rian Jun 4
tesksJun 4
Code context — business-api's FirmApi/StaffApi expose no balance accessor; the logic already exists internally as FirmTransactionService.getAggregateBalance(firmId) (sum over FirmAccountsMapper.listAccountsByFirm via treasury.getBalanceByAccountId).

Approach: add BigDecimal getTotalBalance(int firmId) (+ a formatted variant) to FirmApi, implement in FirmApiDelegate by delegating to FirmTransactionService (inject it into BusinessApiImpl). Prerequisite for PAR-57 (the PAPI placeholder consumes this).
tesks edited the description Jun 4
ParadauxIO linked a commit: Commit 8d9588b — Expose firm total balance in the public BusinessApi (PAR-22) Jun 5
tesks set status to Pending Release Jun 5
tesksJun 5
Shipped on develop (commit 8d9588b).

Added to FirmApi (the business-api public surface):
- BigDecimal getTotalBalance(int firmId)
- String getFormattedTotalBalance(int firmId) (Treasury-formatted)
Both sum across all of a firm's treasury accounts, delegating to the existing FirmTransactionService.getAggregateBalance / getFormattedAggregateBalance (now injected into the FirmApiDelegate). Throws IllegalStateException if the firm has no accounts, documented on the interface.

This unblocks the PAPI expansion in PAR-57. Delegate tests added; coverage gate green.
ParadauxIO linked a pull request: PR #6 open — Release: develop → main Jun 5
ParadauxIO linked a pull request: PR #6 open — Release: develop → main Jun 6

Workspace permission required to comment

Comments and reactions require workspace permission. Ask a workspace owner or admin for access. You can sign in to vote.