[chestshop] Collapse the PreShopCreation + PreTransaction validation pipelines into services (Phase 3)

Part 1 done (commit 268a25a, pushed): shop-creation pipeline collapsed. PreShopCreationEvent is now a plain carrier; ShopService.create(player, sign, lines) runs the 12 former validators as ordered steps in their exact priority+registration order (the two ignoreCancelled steps — fee charge + NameChecker's HIGHEST pass — guarded on !isCancelled). SignCreate calls it directly; registerPreShopCreationEvents removed. Integration events (ItemParse/AccountQuery/AccountAccess/BuildPermission) still fire. Builds + tests green.

Remaining:

• Part 2: collapse the PreTransactionEvent pipeline (PlayerInteract entrypoint; LOWEST validators + the partial/non-partial alternative — PartialTransactionModule XOR AmountAndPriceChecker — + StockFittingChecker + PermissionChecker + ErrorMessageSender with owner notifications). The hot trade path — wants its own careful pass + smoke test.
• Cleanup: strip the now-inert @EventHandler/Listener markers from both validator sets (left in place for now; harmless since unregistered).

Part 2 done (commit 04b9f28, pushed): pre-transaction pipeline collapsed. PreTransactionEvent is now a plain carrier; TransactionService.validate(ctx) runs the former pretransaction validators in exact priority+registration order (the partial/non-partial alternative preserved; AmountAndPriceChecker's ignoreCancelled guarded). PlayerInteract calls it directly; registerPreTransactionEvents removed. Builds + tests green.

Both internal validation pipelines (PreShopCreation + PreTransaction) and the entire economy event bus are now plain service calls.

Remaining cleanup (cosmetic, not yet done): strip the now-inert @EventHandler/Listener markers from the ~22 former validator classes — they're unregistered and called directly, so harmless, but misleading. ~60 mechanical edits; deferred to keep this from sprawling.

"Zero events" status: the internal coordination/validation/economy events are gone. What remains as events is intentional — genuine cross-plugin integration points (AccountQuery/AccountAccess → Treasury/Business, BuildPermission → WorldGuard/GriefPrevention, ItemParse/ItemString → custom-item plugins), Bukkit platform events (SignChange/PlayerInteract/BlockBreak), and the post-event fan-outs (TransactionEvent, ShopCreated/ShopDestroyed → loggers/market/messages) which are observer-style "it happened" notifications — a possible future phase if you want those collapsed too.

Increment A done (commit 2e5b567): eliminated AccountQueryEvent + AccountAccessEvent. Account resolution/access now run as direct API calls through AccountService.resolveAccount/canAccess → EconomyService (which gained the BusinessApi handle + a 4-arg bind). TreasuryListener no longer holds account state — it only advertises the provider and migrates legacy business signs. Deleted AccountListener and both event classes.

Remaining increments toward zero custom events: B TransactionEvent fan-out, C ShopCreated/ShopDestroyed, D item-parse/material/sign-validation (custom-item plugin integration → API), E protection (BuildPermission/ProtectionCheck/ProtectBlock → WorldGuard/GriefPrevention via API), F ShopInfo/ItemInfo/ChestShopReload, plus stripping the now-inert @EventHandler/implements Listener markers off the collapsed validator classes.

Increment B done (commit ada7433): TransactionEvent is now a plain carrier; its 8-handler fan-out runs as ordered calls in TransactionService.process (faithful priority + ignoreCancelled order). Sign migration moved to EconomyService.migrateLegacyBusinessSign; TreasuryListener is now handler-free. Deleted TransactionExecutor; de-registered EmptyShopDeleter/TransactionLogger/TransactionMessageSender/MetricsModule and MarketListener.onTransaction.

Also fixed two silently-dropped handlers from the earlier carrier collapses (they were registered but inert, logging a severe at startup): RestrictedSign.onPreTransaction (restricted-shop trade gate) → validate(); StockCounterModule.onPreShopCreation (counter seeding) → create().

Next: C ShopCreatedEvent/ShopDestroyedEvent.

Increment C done (commit f540e91): ShopCreatedEvent/ShopDestroyedEvent collapsed into ShopService.onCreated/onDestroyed (faithful priority order). Firing sites (SignCreate, SignBreak.sendShopDestroyedEvent, EmptyShopDeleter) call the service directly. Deleted ShopRefundListener; de-registered the post-creation/removal loggers + message sender; MarketListener shop handlers now static (still registered for onInventoryClose).

Now mapping D (ItemParseEvent/ItemStringQueryEvent/MaterialParseEvent/SignValidationEvent) — these may be genuine external custom-item extension points (ItemBridge/Nexo/etc.), so checking whether they collapse to internal calls or must become direct third-party API calls before touching them.

Increment D done (commit e90548d): ItemParseEvent/ItemStringQueryEvent/MaterialParseEvent/SignValidationEvent collapsed into a new ItemService (ChestShop.items()) with faithful priority ordering (parse: ItemBridge→alias→vanilla; stringify: ItemBridge→vanilla→alias). SignParseListener/ItemStringListener de-registered; ItemAliasModule is now a Guice @Singleton (same instance registered only for its reload handler); ItemBridge's resolvers are static and only invoked when the plugin is hooked (Dependencies calls ItemService.enableItemBridge()), keeping com.jojodmo.itembridge off the path when absent. ~15 firing sites rewired.

Remaining: E (BuildPermissionEvent/ProtectionCheckEvent/ProtectBlockEvent → WorldGuard/GriefPrevention via direct API), F (ShopInfoEvent/ItemInfoEvent/ChestShopReloadEvent), plus stripping inert @EventHandler markers off the unregistered validator classes.

Increment E done (commit f5619cc): protection events collapsed into ProtectionService (ChestShop.protection()). canAccess/canView run vanilla shop-member check then WorldGuard (deny-if-either); canBuild runs WorldGuard then GriefPrevention with the ignoreCancelled skip preserved. WG/GP integration classes are no longer Listeners — Dependencies wires them as method references only when the plugin is hooked + flag on, so com.sk89q/me.ryanhamshire stay off the path when absent. ProtectBlockEvent deleted (no handlers since PAR-285 removed LWC/Lockette; Security.protect returns false, had no callers).

Last group: F — ShopInfoEvent/ItemInfoEvent/ChestShopReloadEvent (ItemInfoEvent is the intricate one: ~15 contributor handlers + a nested crossbow-projectile sub-query). Then the inert-marker cleanup.

Increment F done (commit c2e957f): ShopInfoEvent/ItemInfoEvent/ChestShopReloadEvent collapsed into InfoService (ChestShop.info()). collectItemInfo runs the basic + extended /iteminfo contributors in firing order (HIGH map/potion override the basic by key); /chestshop reload calls loadConfig() + ItemService.reloadAliases() directly. The info listeners, ItemAliasModule and the vanilla plugins/ChestShop protection class are de-registered.

Milestone: zero internal custom events. All 12 ChestShop custom events are now plain carriers or deleted; nothing is dispatched through Bukkit's event bus internally. Treasury/Business + WorldGuard/GriefPrevention/ItemBridge are reached via direct API links. Only genuine platform-event listeners remain. Six revertable commits: 2e5b567, ada7433, f540e91, e90548d, f5619cc, c2e957f.

Final step in progress: stripping the now-inert @EventHandler/implements Listener markers off the ~26 unregistered validator/info classes (cosmetic; they cause no runtime effect since unregistered classes are never reflected).