Loading issues
Sibling to PAR-141, which reconciled Treasury access on the player transfer path (completeTransferProprietorship) and role-permission edits — but missed the admin-override path.
/firm admin set proprietor <firm> <player> → FirmServiceImpl.adminSetProprietor → updateProprietor(...) flips firm.proprietor_uuid_bin only. It never calls reassignAccountsToNewProprietor, never touches Treasury members/authorizers, and writes no firm_transfer_requests row. Result is identical to the PAR-141 bug: the new proprietor is locked out of the firm's corporate account ("you're not an authorizer"), and the previous owner keeps owner-level access.
3 active firms in this exact state, all with proprietor ≠ account owner, no transfer row, and firm.updated_at == firm.created_at (see note below):
(Separately, ~13 firms are stranded via the transfer path because PAR-141 is Pending Release / not yet deployed to this server — those resolve on deploy + the one-time backfill.)
updated_at is not a reliable audit signalFirmMapper.updateFirm writes updated_at = updated_at, which suppresses the ON UPDATE CURRENT_TIMESTAMP bump, so updated_at stays equal to created_at for a firm's whole life regardless of edits. Flagging separately; not changed here.
FirmServiceImpl.adminSetProprietor: now mirrors the transfer-accept flow — resign the new proprietor if they're a current employee, updateProprietor, then reassignAccountsToNewProprietor(firmId, newProprietor). Wrapped in @Transactional (lazy Provider<FirmAccountService> to break the DI cycle).FirmRequestServiceImpl.completeTransferProprietorship: added @Transactional so a reassignment failure rolls back the proprietor change instead of stranding the account (hardens PAR-141 against partial failure).adminSetProprietor now asserts the account reassignment and covers the resign-when-employee branch. :business:build green incl. the ≥95% coverage gate.One-time SQL backfill reassigns the stranded accounts to their current proprietor (owner + member + authorizer), revoking the previous owner where they're not a current employee. Script prepared (ops/backfill-firm-transfer-accounts.sql) for the 13 transfer-path firms; the 3 admin-path firms above need owner confirmation first (unclear whether Planke32 or the account-owner is the intended owner).