Business GUIs (/firm menu)

Re-add a /firm menu GUI (equivalent to the one that existed before) — possibly using the 1.21 Dialog API. Need to track down what functionality the old menu had.

Technical notes — No GUI/menu/Inventory code exists anywhere in the plugin today (commands are chat-only) — nothing was removed, it never existed here. Add a MenuCommands @Route("menu [firm]") opening a Paper inventory GUI (or Dialog) surfacing existing service actions: info/balance (FirmTransactionService.getAggregateBalance), staff hire/fire (FirmStaffService), accounts (FirmAccountService), deposit/withdraw/pay. Net-new, additive.

Implementation evidence — 2026-10-22

• Isolated branch par-8-firm-menu from current origin/develop; upstream PRs inspected, no existing PAR-8 implementation.
• Native Usher dialogs reuse the existing ChestShop form pattern: firm chooser, aggregate balance, staff/account listings, deposit/withdraw/pay, hiring/firing, create/default account.
• Every submission dispatches the existing /firm command, preserving current server permission, firm-role, Treasury access and notification behavior. Single-use session prevents callback replay; no inventory items are created.
• Business unit tests and startup checks with Carbon/PlaceholderAPI absent passed (:business:test :business:testWithoutCarbon :business:testWithoutPlaceholderApi -PskipIT -Pci=true --offline). Full Business check and real Paper dialog callback journeys are running against disposable DB par8_menu and dedicated ports.
• Matching/services unchanged to avoid PAR-235/PAR-159 overlap. No Minecraft upgrade, shared staging or production changes.
• Draft PR and final verification evidence pending; task remains In progress.

Verification and draft PR — 2026-10-22

• Draft PR: https://github.com/ParadauxIO/hibernia-economy/pull/82 — base develop, head par-8-firm-menu, commit 2cf906836a02788cbd0d5f81d59f745e4c1005fe. Metadata/body and uploaded flow diagram verified; worktree clean.
• PASS: bash gradlew :business:check -Pci=true --offline --no-daemon — 703 tests, static analysis, formatting, coverage 95.96% LINE / 90.00% BRANCH. Optional Carbon/PlaceholderAPI absence suites each passed four tests.
• PASS: bash gradlew :business:test :business:testWithoutCarbon :business:testWithoutPlaceholderApi -PskipIT -Pci=true --offline --no-daemon.
• PASS: bash gradlew spotlessApply spotlessCheck -Pci=true --offline --no-daemon.
• PASS: IT_WORK_DIR="$PWD/.context/par8run" IT_MC_PORT=28608 IT_RCON_PORT=28618 IT_REST_PORT=18608 IT_WEBHOOK_PORT=18618 IT_BYTEBIN_PORT=18628 IT_DB_PORT=34608 IT_DB_NAME=par8_menu IT_GRADLE_ARGS=--offline bash ops/integration/run.sh -- --tests '*business.FirmMenuTest' — two real Paper 1.21.11 callback journeys: chooser, account create, $1.25 deposit with exact ledger effects, hire/accept/fire, denied employee withdrawal, finance permission revoked after form opened. Disposable runtime shut down.
• Six new focused unit tests cover dispatch arguments, replay prevention, malformed/missing fields, selection constraints and permission revocation. Runtime supports Java 21 without duplicating PR80 upgrade work.
• Gaps: rendered Minecraft screenshots/form sizing and large-list visual inspection; Bedrock/Geyser and Minecraft 26.3 compatibility not certified. PR remains draft and Tasklie remains In progress, not Done. No merge, deployment, shared staging/production writes or external messages.

Hybrid UX revision — 2026-10-22

• User requested a Curator/Usher mix. Curator now provides firm chooser, balance dashboard and 45-entry paginated staff/account lists. Usher handles money/staff/account text forms; Back reloads the Curator dashboard.
• Register/shutdown Curator with Business lifecycle; preserve permission checks and single-use transitions/submissions. Recheck list permissions when showing cached list screens.
• Hybrid paging, selection and transition unit tests pass; real Paper chooser → dashboard → list → Usher → Back/account/deposit/staff journeys passed in initial run. Inventory escape test initially stopped at an overlong synthetic username; corrected and final dedicated runtime run in progress.
• Draft PR #82 will be updated after final checks. Existing screenshot/Bedrock gaps remain.

Hybrid UX verified and pushed — 2026-10-22

• Updated draft PR https://github.com/ParadauxIO/hibernia-economy/pull/82 at 918940daf2f6813c118ace955158a914df6feac9; target develop, clean worktree. PR body and uploaded Curator/Usher diagram read back and verified.
• Curator chooser/dashboard/paginated lists + Usher input forms implemented. Form Back reloads fresh dashboard data. Added empty-state regression coverage after discovering Curator reserves content slots. Chooser preserves business.list; cached lists recheck their list permission.
• PASS bash gradlew :business:spotlessApply :business:check -Pci=true --offline --no-daemon: 707 tests, message-key audit, startup and disposable DB checks, coverage 95.80% LINE / 90.28% BRANCH. Carbon and PlaceholderAPI absence suites each passed four tests.
• PASS bash gradlew spotlessApply spotlessCheck -Pci=true --offline --no-daemon.
• PASS IT_WORK_DIR="$PWD/.context/par8verified" IT_MC_PORT=28608 IT_RCON_PORT=28618 IT_REST_PORT=18608 IT_WEBHOOK_PORT=18618 IT_BYTEBIN_PORT=18628 IT_DB_PORT=34608 IT_DB_NAME=par8_menu_hybrid IT_GRADLE_ARGS=--offline TMPDIR="$PWD/.context/par-8" bash ops/integration/run.sh -- --tests '*business.FirmMenuTest': three real Paper journeys, including empty/populated chooser; inventory/list → dialog → Back; account creation; exact $1.25 deposit and ledger assertions; hire/accept/fire; server finance permission revoked after opening form; financial firm-role demotion after opening form; pickup/shift/hotbar/offhand/drop/drag/creative-clone/stale-window item-escape attempts. Positive control transferred items from an ordinary chest.
• Disposable stack stopped; all six dedicated ports verified closed. No shared staging/production changes, upgrade work, merge or deployment.
• Remaining: actual rendered Minecraft screenshots, visual sizing/large-list inspection and Bedrock/Geyser validation. Task remains In progress and PR remains draft.

Merged — 2026-10-22

• User explicitly authorized merging PR #82. All GitHub checks passed, including JVM build, mutation testing, live-server integration and ci-gate.
• PR https://github.com/ParadauxIO/hibernia-economy/pull/82 merged into develop at 2026-10-22 10:34:05 UTC; merge commit 90d28dffdfff8b46100260e1d43c90c77f5686ab.
• Merge verified through GitHub. No deployment performed. Existing rendered-client/Bedrock validation gaps remain; this evidence does not mark the task Done.