You’re viewing Paradaux’s public workspaceSign in to vote Get taskl.ie for your team

PAR-421

Loading issues

PAR-421 · D8 · GitHub domain: webhook adapter, PR/branch links on… · Paradaux · taskl.ie

PAR-421

D8 · GitHub domain: webhook adapter, PR/branch links on issues, automations, outbox senders

Domain migration. Depends on D2 and PAR-412. It pairs with D6, so coordinate on the webhook entry point.

GithubWebhookService becomes a thin adapter feeding a github facade:
- link PRs, branches and commits to issues (IssueRefScanner moves into the domain)
- automations: PR opened → In progress, merged → Pending release, live → Done (configurable, matching the PAR-384 GitHub settings design)
Outbound GitHub calls go through the outbox.
Development panel: expose PR state, review status, checks and the branch on the issue read model (PAR-404).
GithubMcpTools moves to github/mcp.

Acceptance

Tests pass (webhook fixtures), and the ArchUnit store and ESLint suppressions shrink.

Activity

taskl.ie created the issue 6d ago
taskl.ie5d ago
Notes from the PAR-415 merge (#54):
- Remove these grandfathered ArchUnit entries: GithubWebhookService.transitionByType and transitionTo → TaskModels.Task.ref.
- Outbox: issue activity reaches the GitHub sink through the issue.activity outbox handler.
- Kysely: lib/sql/github.ts resolveIssueRepo still reads project.github_repo (see the PAR-418 handoff).
taskl.ie set status to In Progress 5d ago
taskl.ie5d ago
Plan (branch par-421-github off rebuild):
- New domain io.paradaux.tasklie.github behind GithubFacade (model / persistence / usecase / api / mcp / client / job / port). Sealed GithubEvent model so PAR-419 can add a deployment event + use case without touching the adapter's signature checks.
- GithubWebhookController stays at /api/public/github/webhook: constant-time HMAC check kept, then ONE facade call per delivery. Delivery id is recorded in the same transaction as the handling (idempotent, and a failed handling can be redelivered).
- Status moves go through IssuesFacade (statuses resolved by id from the repo link, or by kind via WorkspacesFacade); activity events recorded through a new IssuesFacade.recordActivity (no SQL on issues from here, no use of issues.event from outside).
- Outbound: PR summary comments are github.pr_comment outbox messages with idempotency keys; GithubActivitySink becomes a thin sink in activity/job calling the facade, which enqueues them.
- Settings REST under /api/public/w/{slug}/github (reads members-only, writes settings.manage); MCP tasklie_list_repos / tasklie_update_repo move to github/mcp.
- Web: domains/github data + settings screen; delete lib/sql/github.ts. Known gap I will flag: the release-PR snapshot (develop -> main) cannot move without new ArchUnit entries; PAR-419 replaces releases.
taskl.ie5d ago
PR open: https://github.com/ParadauxIO/taskl.ie/pull/56 (against rebuild). ArchUnit store 1014 -> 885 distinct entries, 0 added; eslint suppressions 61 -> 58. Known gap: the release-PR snapshot (develop -> default) is no longer created, because calling ReleaseService from the new domain needs TenantContext and would add store entries; left for PAR-419. Waiting on CI.
taskl.ie set status to Pending Release 5d ago
taskl.ie5d ago
Merged into rebuild as #56.

What's in it
- Webhook handling: GithubWebhookController is now a thin adapter. It verifies the HMAC in constant time, then sends a sealed GithubEvent to GithubFacade.receive. Delivery ids are idempotent within the same transaction.
- Automations: status changes go through IssuesFacade, and statuses are looked up by id or kind.
- PR comments: sent through the outbox, with retries.
- Projects: read through ProjectsFacade. No project SQL is left in github/.
Security
- Fixed an installation takeover: re-linking an installation that belongs to another workspace now returns 409.
- Repo link saves now reject status and team ids from another workspace.
- Dev links are members-only, both on GitHub reads and in IssuesFacade.get.
Ratchet
- ArchUnit store: 820 → 691 distinct entries, none added. This also removes the grandfathered GithubWebhookService entries.
- ESLint suppressions: 26 → 23.
Gaps and handoffs
- The release-PR snapshot regression must be restored by PAR-419 before rebuild ships.
- PR review and check-run state are not built yet.
- The PAR-419 handoff and the PAR-384 handoff (settings UI uses the @/domains/github data plus the repo_link automation fields) are in the agent's report.
taskl.ie5d ago
Merged into rebuild as #56.

What's in it
- Webhook handling: GithubWebhookController is now a thin adapter. It verifies the HMAC in constant time, then sends a sealed GithubEvent to GithubFacade.receive. Delivery ids are idempotent within the same transaction.
- Automations: status changes go through IssuesFacade, and statuses are looked up by id or kind.
- PR comments: sent through the outbox, with retries.
- Projects: read through ProjectsFacade. No project SQL is left in github/.
Security
- Fixed an installation takeover: re-linking an installation that belongs to another workspace now returns 409.
- Repo link saves now reject status and team ids from another workspace.
- Dev links are members-only, both on GitHub reads and in IssuesFacade.get.
Ratchet
- ArchUnit store: 820 → 691 distinct entries, none added. This also removes the grandfathered GithubWebhookService entries.
- ESLint suppressions: 26 → 23.
Gaps and handoffs
- The release-PR snapshot regression must be restored by PAR-419 before rebuild ships.
- PR review and check-run state are not built yet.
- The PAR-419 handoff and the PAR-384 handoff (settings UI uses the @/domains/github data plus the repo_link automation fields) are in the agent's report.
taskl.ie changed status from Pending release to Done 5d ago

Workspace permission required to comment

Comments and reactions require workspace permission. Ask a workspace owner or admin for access. You can sign in to vote.